From 7b9d1c604099dd21d6c710ca00dfd9b001afc172 Mon Sep 17 00:00:00 2001
From: Kurt Himebauch <136133082+xXJSONDeruloXx@users.noreply.github.com>
Date: Thu, 10 Sep 2026 16:41:00 -0400
Subject: test: keep steam shortcut discovery flatpak agnostic

---
 tests/test_steam_service.py | 32 +++++++++++++++-----------------
 1 file changed, 15 insertions(+), 17 deletions(-)

(limited to 'tests')

diff --git a/tests/test_steam_service.py b/tests/test_steam_service.py
index 3f0283b..76cdf47 100644
--- a/tests/test_steam_service.py
+++ b/tests/test_steam_service.py
@@ -11,23 +11,11 @@ sys.modules.setdefault(
 )
 sys.path.insert(0, str(Path(__file__).resolve().parents[1] / "py_modules"))
 
-from lsfg_vk.steam_service import SteamService, is_direct_flatpak_shortcut
+from lsfg_vk.steam_service import SteamService
 
 
 class SteamShortcutTests(unittest.TestCase):
-    def test_only_direct_flatpak_targets_are_special(self):
-        self.assertTrue(is_direct_flatpak_shortcut("/usr/bin/flatpak"))
-        self.assertTrue(is_direct_flatpak_shortcut("flatpak"))
-        self.assertTrue(is_direct_flatpak_shortcut("/usr/bin/flatpak run com.example.Game"))
-        self.assertTrue(is_direct_flatpak_shortcut('~/.lsfg "/usr/bin/flatpak"'))
-        self.assertTrue(is_direct_flatpak_shortcut('~/lsfg "usr/bin/flatpak"'))
-        self.assertTrue(is_direct_flatpak_shortcut('~/.local/bin/mako-run "/usr/bin/flatpak"'))
-        self.assertFalse(is_direct_flatpak_shortcut("/usr/bin/bash"))
-        self.assertFalse(is_direct_flatpak_shortcut("/home/deck/Emulation/tools/launchers/retroarch.sh"))
-        self.assertFalse(is_direct_flatpak_shortcut("/home/deck/Emulation/tools/launchers/ppsspp.sh"))
-        self.assertFalse(is_direct_flatpak_shortcut("/home/deck/AppImages/dusk.appimage"))
-
-    def test_shortcut_data_preserves_launch_shape_without_flatpak_identity(self):
+    def test_direct_flatpak_shortcut_is_ordinary_non_steam_metadata(self):
         game = SteamService._shortcut_game(
             {
                 "appid": 123456,
@@ -39,13 +27,15 @@ class SteamShortcutTests(unittest.TestCase):
         )
 
         self.assertEqual(game["appid"], "123456")
-        self.assertTrue(game["directFlatpak"])
+        self.assertEqual(game["name"], "PCSX2 shortcut")
+        self.assertTrue(game["nonSteam"])
+        self.assertNotIn("directFlatpak", game)
         self.assertNotIn("transport", game)
         self.assertEqual(game["executable"], "/usr/bin/flatpak")
         self.assertEqual(game["arguments"], "run net.pcsx2.PCSX2 --fullscreen")
         self.assertEqual(game["startDir"], "/home/deck/Games")
 
-    def test_emudeck_launcher_is_ordinary_non_steam(self):
+    def test_emudeck_launcher_is_ordinary_non_steam_metadata(self):
         game = SteamService._shortcut_game(
             {
                 "appid": 987654,
@@ -55,11 +45,19 @@ class SteamShortcutTests(unittest.TestCase):
             }
         )
 
-        self.assertFalse(game["directFlatpak"])
+        self.assertEqual(game["appid"], "987654")
+        self.assertTrue(game["nonSteam"])
+        self.assertNotIn("directFlatpak", game)
         self.assertEqual(
             game["executable"],
             '"/home/deck/Emulation/tools/launchers/retroarch.sh" -L core rom.z64',
         )
+        self.assertEqual(game["arguments"], "")
+
+    def test_shortcut_rejects_invalid_identity(self):
+        self.assertIsNone(SteamService._shortcut_game({"appid": 0, "AppName": "Bad"}))
+        self.assertIsNone(SteamService._shortcut_game({"appid": 1, "AppName": ""}))
+        self.assertIsNone(SteamService._shortcut_game("bad"))
 
 
 if __name__ == "__main__":
-- 
cgit v1.2.3