From bc75bb93d5aa9aa176262a138f47d3a1d53afbcb Mon Sep 17 00:00:00 2001 From: xXJSONDeruloXx Date: Thu, 10 Sep 2026 00:25:58 -0400 Subject: fix: simplify Flatpak runtime toggles --- tests/test_flatpak_service.py | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) (limited to 'tests/test_flatpak_service.py') diff --git a/tests/test_flatpak_service.py b/tests/test_flatpak_service.py index 274c0c5..70ba228 100644 --- a/tests/test_flatpak_service.py +++ b/tests/test_flatpak_service.py @@ -93,7 +93,8 @@ class FlatpakServiceTests(unittest.TestCase): response = self.service.install_extension("24.08") self.assertTrue(response["success"]) - self.assertTrue(response["owned_by_plugin"]) + self.assertTrue(response["enabled"]) + self.assertTrue(response["installed"]) install_args = self.service._run_flatpak_command.call_args_list[1].args[0] self.assertEqual(install_args[:4], ["install", "--user", "--noninteractive", "--or-update"]) self.assertEqual( @@ -110,28 +111,33 @@ class FlatpakServiceTests(unittest.TestCase): cleanup_response = self.service.remove_plugin_owned_extensions() self.assertTrue(install_response["success"]) - self.assertFalse(install_response["owned_by_plugin"]) + self.assertTrue(install_response["enabled"]) + self.assertTrue(install_response["installed"]) self.assertFalse(self.service.ownership_path.exists()) self.assertTrue(cleanup_response["success"]) self.assertEqual(self.service._run_flatpak_command.call_count, 1) - def test_extension_toggle_is_idempotent_and_preserves_preexisting_branch(self): - self.service._run_flatpak_command.return_value = self._result( - self._extension_line("24.08") - ) + def test_extension_toggle_installs_and_uninstalls_preexisting_branch(self): + self.service._run_flatpak_command.side_effect = [ + self._result(self._extension_line("24.08")), + self._result(self._extension_line("24.08")), + self._result(""), + self._result(""), + ] enable_response = self.service.set_extension_enabled("24.08", True) disable_response = self.service.set_extension_enabled("24.08", False) self.assertTrue(enable_response["success"]) self.assertTrue(enable_response["enabled"]) + self.assertTrue(enable_response["installed"]) self.assertTrue(disable_response["success"]) - self.assertTrue(disable_response["enabled"]) - self.assertTrue(disable_response["preserved"]) - self.assertFalse(disable_response["owned_by_plugin"]) + self.assertFalse(disable_response["enabled"]) + self.assertFalse(disable_response["installed"]) + self.assertTrue(disable_response["removed"]) self.assertEqual( [call.args[0][0] for call in self.service._run_flatpak_command.call_args_list], - ["list", "list"], + ["list", "list", "uninstall", "list"], ) def test_extension_toggle_removes_owned_branch_and_can_repeat_disable(self): -- cgit v1.2.3